Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several ACL token/policy resolution issues. #5246

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Commits on Jan 18, 2019

  1. Fix 2 remote ACL policy resolution issues

    1 - Use the right method to fire async not found errors when the ACL.PolicyResolve RPC returns that error. This was previously accidentally firing a token result instead of a policy result which would have effectively done nothing (unless there happened to be a token with a secret id == the policy id being resolved.
    
    2. When concurrent policy resolution is being done we single flight the requests. The bug before was that for the policy resolution that was going to piggy back on anothers RPC results it wasn’t waiting long enough for the results to come back due to looping with the wrong variable.
    mkeeler committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    e9f2a5f View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Configuration menu
    Copy the full SHA
    8095a2f View commit details
    Browse the repository at this point in the history
  2. Update agent/consul/acl_test.go

    Co-Authored-By: mkeeler <mkeeler@users.noreply.github.com>
    banks and mkeeler committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    0a60325 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e8a00c6 View commit details
    Browse the repository at this point in the history