Ensure Consul is IPv6 compliant #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
requested changes
Mar 11, 2019
|
@mkeeler Yes, I am gonna add a few test in next commit |
rboyer
reviewed
Mar 11, 2019
Ensure that when we format address:port if the address is IPv6, we format it using "[%s]:%d" instead of "%s:%d". This should fix hashicorp#5460
We ensure that `sidecarServiceFromNodeService` default check use the same IP as sidecar.Proxy.LocalServiceAddress If we enforce ipv6 address there, the check will be correct. Added unit test with both IPv4 and IPv6 to ensure the TCP check is correct
… when port is an int
pierresouchay
force-pushed
the
format_ipv6
branch
from
96c321d
to
7a14404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when we format address:port if the address is IPv6, we
format it using "[%s]:%d" instead of "%s:%d".
This should fix #5460