[docs] WIP ports page #5693
Merged
[docs] WIP ports page #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitlincart
added
the
type/docs
pearkes
reviewed
May 7, 2019
There was a problem hiding this comment.
Do we want to remove the "ports used" section from the configuration doc? Instead we could link to the new ports required page at the beginning of the options page.
Yes I think we should just add a reference to it.
I like this being all on the same page and limiting sprawl so +1 from me. We should also probably get in the content updates #5610 that @s-christoff did in the section we'll be removing.
kaitlincart
added a commit
that referenced
this pull request
May 8, 2019
* Updating ports information to be consistent accross docs. * adding some extra notes based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bases on issue #5690
Updates Include:
Thoughts:
Do we want to remove the "ports used" section from the configuration doc? Instead we could link to the new ports required page at the beginning of the options page. The benefit of removing the "ports used" section would be to reduce spread. The benefit of having a Ports Required page is it makes this information easy to discover when navigating the site.