ui: CSS/Visual Refinements #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
feature/ui-service-identities
branch
from
14636de
to
fa17fc8
Compare
added 2 commits
April 29, 2019 11:33
1. Introduce the idea of 'policy types' instead of just 'is-management' with a new policy/typeof helper 2. Add placeholders for all structure icons, and start replacing the older ones. 3. %pills no default to transparent, the gray is added at a project level 4. Started to introduce a saner way to size tables, basically sane defaults with the ability to overwrite for the more involved tables
1. Mainly working on tables, all tds are now inline-flex
2. The inline flex meant we could remove a lot of cruft and spacing from
other areas
3. Spotted an area that wasn't using {{tag-list}}
johncowen
force-pushed
the
feature/ui-acl-visuals
branch
from
cfa8cbb
to
69b7992
Compare
added 4 commits
April 29, 2019 12:15
This adds a 'service' icon to service identity type policies and a 'star' icon to the global management type policies
pearkes
approved these changes
May 1, 2019
johncowen
added a commit
that referenced
this pull request
May 1, 2019
Adds support for ACL Roles and Service Identities CRUD, along with necessary changes to Tokens, and the CSS improvements required. Also includes refinements/improvements for easier testing of deeply nested components. 1. ember-data adapter/serializer/model triplet for Roles 2. repository, form/validations and searching filter for Roles 3. Moves potentially, repeated, or soon to to repeated functionality into a mixin (mainly for 'many policy' relationships) 4. A few styling tweaks for little edge cases around roles 5. Router additions, Route, Controller and templates for Roles Also see: * UI: ACL Roles cont. plus Service Identities (#5661 and #5720)
johncowen
added a commit
that referenced
this pull request
May 1, 2019
Adds support for ACL Roles and Service Identities CRUD, along with necessary changes to Tokens, and the CSS improvements required. Also includes refinements/improvements for easier testing of deeply nested components. 1. ember-data adapter/serializer/model triplet for Roles 2. repository, form/validations and searching filter for Roles 3. Moves potentially, repeated, or soon to to repeated functionality into a mixin (mainly for 'many policy' relationships) 4. A few styling tweaks for little edge cases around roles 5. Router additions, Route, Controller and templates for Roles Also see: * UI: ACL Roles cont. plus Service Identities (#5661 and #5720)
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes mainly visual changes (mainly just CSS) to include visual refinements to the new ACLs areas but also refinements throughout the UI.
$icon-name-svgSASS variable, also now has its own%with-<name-of-svg>-iconplaceholder. This paired with a%as-pseudoplaceholder makes it simple to use these icons, but as it does less, is more reusable then the approach I had from the initial re-build of the UI as it. The majority of icons will now begin to move towards this. Here we've replaced the info icon we use for external documentation links and some tooltips, and the '3 horizontal dots' we use for the action buttons on table rows.is-managementhelper for policies to a more generictypeofhelper, which enables us to distinguish between 'types' of policy-like things for icon-ing purposes.inline-flexwhich meant we could remove a reasonable amount of finickity values, but also some refactoring of fonts/colors to reflect newer designs. Also we added 'default' sizing for columns (2 cols = 50%/50%, 3 cols = 33%/33%/33% etc) which means we don't need so much specific row naming/sizing.TBDThere's more work to do here, mainly moving more and more of our old icons over to the Structure set, but we are going to leave this for future PRs.