ui: Normal proxies link to services, sidecars to instances #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
changed the base branch from
bugfix/ui-gh5853-unique-node-service
to
master
johncowen
force-pushed
the
bugfix/ui-correct-proxy-links
branch
2 times, most recently
from
a9d9778
to
7c8734c
Compare
Folllowing on from #5933 we noticed that 'normal' proxies should link to the service, rather than the service instance. Additionally sideproxy 'searching' within the repository should take into account the name of the node that the originating service is on (sidecar proxies are generally co-located) Added an additiojnal test here to prove that a sidecar-proxy with the same service id but on a different node does not show the sidecar proxy link.
johncowen
force-pushed
the
bugfix/ui-correct-proxy-links
branch
from
7c8734c
to
1b19e25
Compare
Also use a node name that is different to the node names produced by the api mocks so we know that the test is using the mocks from the specific test
DingoEatingFuzz
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #5933 we
noticed that 'normal' proxies should link to the service, rather than
the service instance. Additionally sidecar proxy 'searching' within the
repository should take into account the name of the node that the
originating service is on (sidecar proxies are generally co-located)
Added an additional test here to prove that a sidecar-proxy with the
same service id but on a different node does not show the sidecar proxy
link.