Fix CAS operations on Services #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
reviewed
Jun 14, 2019
Co-Authored-By: R.B. Boyer <public@richardboyer.net>
banks
approved these changes
Jun 17, 2019
|
Going to merge this even though the envoy integration tests are failing. Those cannot be real failures and are instead due to flaky tests. |
|
Going to merge this even though the envoy integration tests are failing. Those cannot be real failures and are instead due to flaky tests. This PR only touches one thing in the catalog which is only accessed through the Txn API and the envoy integration definitely doesn't use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were asserting the wrong type in this function so we were allowing writes that we shouldn't have.