-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replace-existing-checks param to the api package #6496 #7136
Add replace-existing-checks param to the api package #6496 #7136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @i0rek This is my view based on very limited knowledge of the codebase. The AgentServiceRegistration struct perfectly matches what you expect from the API payload. Example:
Also, we have to ensure that we support the new field everywhere else in the code.
However, I don't mind changing to a flag instead, your call. Thanks! |
Thats a good point! After checking what we did before, I suggest you add an new function that can be extended in future: Lines 512 to 552 in 61d8778
What do you think? |
I like the idea, I will check how to implement the suggested fix tonight. |
…ew struct to hold service registration options. #6496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your work and time to get this done!
Add replace-existing-checks param to the API package #6496