Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Fix positioning of active icon in the selected menu item #7148

Merged
merged 1 commit into from
Jan 28, 2020
Merged

ui: Fix positioning of active icon in the selected menu item #7148

merged 1 commit into from
Jan 28, 2020

Conversation

johncowen
Copy link
Contributor

Before:

Screenshot 2020-01-28 at 09 43 16

(^ notice ca_east-6 is the current datacenter)

After:

Screenshot 2020-01-28 at 09 45 16

@johncowen johncowen added the theme/ui Anything related to the UI label Jan 28, 2020
@johncowen johncowen requested a review from a team January 28, 2020 09:46
@johncowen johncowen added this to the 1.7.0 milestone Jan 28, 2020
kaxcode
kaxcode approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit c6e72c3 into ui-staging Jan 28, 2020
@johncowen johncowen deleted the bugfix/ui-menu-is-active-icon branch January 28, 2020 14:42
@johncowen johncowen mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxcode kaxcode kaxcode approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johncowen @kaxcode