Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add live updates/blocking queries to the Intention listing page #7161

Merged
merged 3 commits into from
Jan 29, 2020
Merged

ui: Add live updates/blocking queries to the Intention listing page #7161

merged 3 commits into from
Jan 29, 2020

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jan 29, 2020 •
edited
Loading

This PR enables blocking queries/live updates for Intentions.

Preview Link

If you add a cookie called CONSUL_LATENCY whilst visiting the above link and then hit refresh you can speed up the rate of change:

Screenshot 2020-01-29 at 11 08 18

500 means fake a change every 500 milliseconds.

@johncowen johncowen added the theme/ui Anything related to the UI label Jan 29, 2020
@johncowen johncowen requested a review from a team January 29, 2020 11:03
kaxcode
kaxcode approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit ac60338 into ui-staging Jan 29, 2020
@johncowen johncowen deleted the feature/ui-intention-live-updates branch January 29, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxcode kaxcode kaxcode approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johncowen @kaxcode