Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase watchLimit to 8192. #7200

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Increase watchLimit to 8192. #7200

merged 2 commits into from
Feb 4, 2020

Conversation

hanshasselberg
Copy link
Member

The previous value was too conservative and users with many instances
were having problems because of it. This change increases the limit to
8192 which reportedly fixed most of the issues with that.

Related: #4984, #4986, #5050.

@hanshasselberg
Increase watchLimit to 8192.
c558d06 
The previous value was too conservative and users with many instances
were having problems because of it. This change increases the limit to
8192 which reportedly fixed most of the issues with that.

Related: #4984, #4986, #5050.
@hanshasselberg hanshasselberg self-assigned this Feb 3, 2020
@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 3, 2020
@hanshasselberg hanshasselberg mentioned this pull request Feb 3, 2020
Closed
@hanshasselberg hanshasselberg requested a review from a team February 3, 2020 12:20
pierresouchay
pierresouchay approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@pierresouchay pierresouchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

banks
banks approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this, I commented on the comment but see what you think.

agent/consul/state/state_store.go Outdated Show resolved Hide resolved
@hanshasselberg hanshasselberg modified the milestones: 1.7.x, 1.7.0 Feb 4, 2020
@banks
Copy link
Member

banks commented Feb 4, 2020

👍 LGTM, thanks Hans

@ghost ghost removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 4, 2020
@hanshasselberg hanshasselberg merged commit f6ec8ed into master Feb 4, 2020
@hanshasselberg hanshasselberg deleted the increase_watch_limit branch February 4, 2020 12:11
@nosammai nosammai mentioned this pull request Apr 25, 2020
Closed
@pierresouchay pierresouchay mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

@pierresouchay pierresouchay pierresouchay approved these changes

Assignees

@hanshasselberg hanshasselberg

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanshasselberg @banks @pierresouchay