Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly detect no alt domain set #7323

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Feb 19, 2020

Previously when no recursors were configured, we would set up a root zone handler which allowed non-fully-qualified domain names to be processed as though they were consul queries.

This bug has existed since 1.5.2

@mkeeler mkeeler added this to the 1.7.x milestone Feb 19, 2020
@mkeeler mkeeler requested a review from a team February 19, 2020 19:27
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@mkeeler mkeeler merged commit 861f754 into master Feb 19, 2020
@mkeeler mkeeler deleted the bugfix/unset-dns-altdomain branch February 19, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants