Backport of various version/requirements checking fixes #7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when checking for ACL modes or versions of servers we would give the various utility functions a list of Serf members to iterate through, pull out the servers and run the checks against. This worked okay when we only have to care about LAN and WAN serf instances but for enterprise we have other Serf instances. The changes in this PR are just the OSS side of things but change things up to go through the router/server lookup infrastructure which tracks server metadata coming from multiple sources. This also happens to fix a bug with ACL replication that would always start new ACL replication routines even when still in legacy ACL mode causing lots of errors in the logs.
mkeeler
force-pushed
the
backport/gossip-feature-advertisement
branch
from
3ef5f43
to
6d0a823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when checking for ACL modes or versions of servers we would give the various utility functions a list of Serf members to iterate through, pull out the servers and run the checks against. This worked okay when we only have to care about LAN and WAN serf instances but for enterprise we have other Serf instances.
The changes in this PR are just the OSS side of things but change things up to go through the router/server lookup infrastructure which tracks server metadata coming from multiple sources.
This also happens to fix a bug with ACL replication that would always start new ACL replication routines even when still in legacy ACL mode causing lots of errors in the logs.
These same changes already exist in master and the 1.7 release branch. This just backports those changes to the 1.6.x release branch.