Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Redesign Service List page #7605

Merged
merged 10 commits into from
Apr 8, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 7, 2020

  • Upgrade @hashicorp/consul-api-double to 2.14.0
  • Create and update tests for service-list page
  • Add tag-svg to codebase
  • Add InstanceCount to the service model
  • Create service health-checks helper
  • Update ConsulsServiceList component with styling
  • Create CompositeRow styling component
  • Update TagList styling
  • Update ListCollection styling
  • Create GridCollection for nodes page with styling

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 7, 2020
@kaxcode kaxcode requested a review from a team April 7, 2020 15:28
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks amazing 👏 , I love the new design here also, more room for content.

I left a few comments but I don't think any of it would be blocking at all, its just nips and tucks here and there and most is kind of up to you.

One thing I did notice that we should probably sort out is the responsiveness of it, we'd best sort that at least before we merge this.

ui-v2/app/styles/components/composite-row/layout.scss Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/index.hbs Outdated Show resolved Hide resolved
ui-v2/app/components/service-list/index.hbs Outdated Show resolved Hide resolved
ui-v2/app/styles/components/service-list.scss Outdated Show resolved Hide resolved
ui-v2/app/templates/dc/services/index.hbs Outdated Show resolved Hide resolved
ui-v2/app/styles/components/service-list/skin.scss Outdated Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/redesign-service-list-page branch 2 times, most recently from 2d75ce8 to 467ce24 Compare April 7, 2020 17:16
@kaxcode kaxcode requested a review from johncowen April 7, 2020 17:18
@kaxcode kaxcode force-pushed the ui/feature/redesign-service-list-page branch from 467ce24 to c94e81f Compare April 7, 2020 18:37
@kaxcode kaxcode force-pushed the ui/feature/redesign-service-list-page branch 2 times, most recently from 57cfe55 to 9841129 Compare April 8, 2020 16:04
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one more comment that I'm not totally sure of, but I think this is good to merge.

I think there is a lot we'll need to do re-org wise here, but agree it would be best to get the service instance listing complete first to get a better idea of how to organize the styling for these lists as I don't think its completely clear yet how to best do this.

Top work! 👍

ui-v2/app/components/list-collection/index.hbs Outdated Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/redesign-service-list-page branch from 9841129 to 02b12fc Compare April 8, 2020 16:59
@kaxcode kaxcode merged commit b2f32e5 into ui-staging Apr 8, 2020
@kaxcode kaxcode deleted the ui/feature/redesign-service-list-page branch April 8, 2020 17:09
kaxcode added a commit that referenced this pull request Apr 20, 2020
* Create GridCollection for nodes page with styling

* Update ListCollection styling

* Update TagList styling

* Create CompositeRow styling component

* Update ConsulServiceList component with styling

* Create service health-checks helper

* Add InstanceCount to the service model

* Add tag-svg to codebase

* Create and update tests for service-list page

* Upgrade @hashicorp/consul-api-double to 2.14.0
johncowen pushed a commit that referenced this pull request Apr 30, 2020
* Create GridCollection for nodes page with styling

* Update ListCollection styling

* Update TagList styling

* Create CompositeRow styling component

* Update ConsulServiceList component with styling

* Create service health-checks helper

* Add InstanceCount to the service model

* Add tag-svg to codebase

* Create and update tests for service-list page

* Upgrade @hashicorp/consul-api-double to 2.14.0
kaxcode added a commit that referenced this pull request May 11, 2020
* Create GridCollection for nodes page with styling

* Update ListCollection styling

* Update TagList styling

* Create CompositeRow styling component

* Update ConsulServiceList component with styling

* Create service health-checks helper

* Add InstanceCount to the service model

* Add tag-svg to codebase

* Create and update tests for service-list page

* Upgrade @hashicorp/consul-api-double to 2.14.0
johncowen pushed a commit that referenced this pull request May 12, 2020
* Create GridCollection for nodes page with styling

* Update ListCollection styling

* Update TagList styling

* Create CompositeRow styling component

* Update ConsulServiceList component with styling

* Create service health-checks helper

* Add InstanceCount to the service model

* Add tag-svg to codebase

* Create and update tests for service-list page

* Upgrade @hashicorp/consul-api-double to 2.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants