Allow to restrict servers that can join a given Serf Consul cluster. #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
force-pushed
the
block_memberlist_using_cidr
branch
5 times, most recently
from
a7749c2
to
58715e9
Compare
|
This PR looks good. Could you rebase so that I can review? |
pierresouchay
force-pushed
the
block_memberlist_using_cidr
branch
from
58715e9
to
1139a46
Compare
|
@i0rek DONE: had to revamp doc. |
hanshasselberg
added
the
waiting-reply
|
@i0rek Done, added the new Unit test for HCL/JSON serialization |
ghost
removed
waiting-reply
Based on work done in hashicorp/memberlist#196 this allows to restrict the IP ranges that can join a given Serf cluster and be a member of the cluster. Restrictions on IPs can be done separatly using 2 new differents flags and config options to restrict IPs for LAN and WAN Serf.
This test does check that blocking IPs works on LAN
pierresouchay
force-pushed
the
block_memberlist_using_cidr
branch
from
e6e62e6
to
d19e8c4
Compare
|
@i0rek The test failing is |
pierresouchay
force-pushed
the
block_memberlist_using_cidr
branch
from
d19e8c4
to
14ad95c
Compare
hanshasselberg
approved these changes
May 20, 2020
rboyer
pushed a commit
that referenced
this pull request
Jun 1, 2020
…7628) Based on work done in hashicorp/memberlist#196 this allows to restrict the IP ranges that can join a given Serf cluster and be a member of the cluster. Restrictions on IPs can be done separatly using 2 new differents flags and config options to restrict IPs for LAN and WAN Serf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work done in hashicorp/memberlist#196
This allows restricting the IP ranges that can join a given Serf cluster and be a member of the cluster.
Restrictions on IPs can be done separately using 2 new differents flags and config options to restrict IPs for both LAN and WAN Serf.
This will allow to secure a bit more clusters as well as protecting non-encrypted clusters from an agent in dev mode to join clusters and thus fixing #5916