Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Model Layer for SSO Support #7771

Merged
merged 4 commits into from
May 5, 2020
Merged

Conversation

johncowen
Copy link
Contributor

This PR adds the majority of the model layer for SSO support in the UI.

Notes:

  1. Addition of an ember-data triplet plus repo as per the rest of the UI.
  2. Addition of the torii addon which we'll be using for the SSO provider interaction. This functionality is available via the repo (think, a repository for providing JWTs)
  3. Addition of a way of specifying that you do not want a blocking query to cache. Our blocking query support caches the last response, so that when you come back to a page the response is immediately available and then the blocking query continues to wait for any updates. Sometimes you don't want this caching functionality to happen, for example when asking for a token. We chose to use the HTTP Cache-Control header here, which fits reasonably well with our HTTPAdapters and means you specify that you want caching disabled along with the rest of the Adapter information.

Integration tests for the new Adapter are added here, following on from the rest of the Adapter tests. Serialiser and repository tests are to follow in another PR.

John Cowen added 4 commits May 4, 2020 13:44
1. oidc-provider ember-data triplet plus repo, plus addition of torii
addon
2. Make blocking queries support a Cache-Control: no-cache header
3. Tweaks to the token model layer in preparation for SSO work
@johncowen johncowen added the theme/ui Anything related to the UI label May 4, 2020
@johncowen johncowen requested a review from a team May 4, 2020 16:47
@johncowen johncowen added this to the 1.8.0 milestone May 4, 2020
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit 0c5eccf into ui-staging May 5, 2020
@johncowen johncowen deleted the ui/feature/sso-model-layer branch May 5, 2020 16:29
kaxcode pushed a commit that referenced this pull request May 11, 2020
* ui: Adds model layer required for SSO

1. oidc-provider ember-data triplet plus repo, plus addition of torii
addon
2. Make blocking queries support a Cache-Control: no-cache header
3. Tweaks to the token model layer in preparation for SSO work

* Fix up meta related Cache-Control tests

* Add tests adapter tests for URL shapes

* Reset Cache-Control to the original value, return something from logout
johncowen added a commit that referenced this pull request May 12, 2020
* ui: Adds model layer required for SSO

1. oidc-provider ember-data triplet plus repo, plus addition of torii
addon
2. Make blocking queries support a Cache-Control: no-cache header
3. Tweaks to the token model layer in preparation for SSO work

* Fix up meta related Cache-Control tests

* Add tests adapter tests for URL shapes

* Reset Cache-Control to the original value, return something from logout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants