Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Misc amends for Safari and Firefox #7907

Merged
merged 1 commit into from
May 18, 2020

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented May 18, 2020

  1. Ensure dropdown menus function correctly in Safari
  2. Ensure default grey color for buttons is not used
  3. Ensure IntersectionObservers are cleaned up properly in Safari.

Fixes #7904

@johncowen johncowen added the theme/ui Anything related to the UI label May 18, 2020
@johncowen johncowen requested a review from a team May 18, 2020 12:21
@johncowen johncowen added this to the 1.8.0 milestone May 18, 2020
1. Ensure dropdown menus function correctly in Safari
2. Ensure default grey color for buttons is not used
3. Ensure IntersectionObservers are cleaned up properly in Safari
@johncowen johncowen force-pushed the ui/bugfix/misc-browser-amends branch from 7818652 to 736fdf1 Compare May 18, 2020 15:28
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johncowen johncowen merged commit 6588218 into master May 18, 2020
@johncowen johncowen deleted the ui/bugfix/misc-browser-amends branch May 18, 2020 16:21
hashicorp-ci pushed a commit that referenced this pull request May 18, 2020
1. Ensure dropdown menus function correctly in Safari
2. Ensure default grey color for buttons is not used
3. Ensure IntersectionObservers are cleaned up properly in Safari
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus in 1.8.0-beta1 do not work in Safari
2 participants