ui: New Empty States #7940
ui: New Empty States #7940
Conversation
| </li> | ||
| <li class="learn-link"> | ||
| <a href="{{env 'CONSUL_DOCS_LEARN_URL'}}/consul/" rel="noopener noreferrer" target="_blank">Follow the guide</a> | ||
| </li> |
There was a problem hiding this comment.
I think this can actually go, you will always be able to at least see the ACL you are logging in with.
| </li> | ||
| <li class="learn-link"> | ||
| <a href="{{env 'CONSUL_DOCS_LEARN_URL'}}/consul/" rel="noopener noreferrer" target="_blank">Read the guide</a> | ||
| </li> |
There was a problem hiding this comment.
I think this can go also, pretty sure you can always see at least one node.
Moving forwards we are going to have the auth-form on the page all the time, even when logged in (for relogging in purposes). This means the auth-form will not always be removed from the DOM when you log in. This sets the form back to its idle state before calling onsubmit
1. Centralize cache resetting elsehwere, for now the store makes most sense, although I would prefer the Repository class, so using the store is temporary 2. We only need to refresh on login once, unless we have a differeing nspace
THis means we can 'relogin' when already logged in
johncowen
force-pushed
the
ui/feature/new-empty-states
branch
from
f44ce20
to
584feec
Compare
| @@ -68,6 +68,7 @@ $gray-7: #b4b8bc; | |||
| $gray-8: #d0d2d5; | |||
| $gray-9: #ebecee; | |||
| $gray-10: #f3f4f6; | |||
| $gray-010: #fbfbfc; | |||
There was a problem hiding this comment.
I think this would be confusing in the future. Can we standardize all these variables to start with a 0? For example, $gray-8 -> $gray-08
There was a problem hiding this comment.
Hmm yeah originally the base files where imagined to be shared between product and marketing. Luckily the marketing teams grays used a gray-<single-digit> naming scheme and we chose a gray-<triple-digit>. Originally there was talk of marketing migrating to use our gray-scale/naming instead, it just never got there.
I think I'm gonna remove all the marketing ones for the moment at least. They don't get compiled in but for folks that don't know the history here it is confusing.
There was a problem hiding this comment.
I commited the removal on the end of this here, gonna merge this!
* ui: CSS and component changes to the <EmptyState /> component * ui: Reset the auth-form component back to its initial state Moving forwards we are going to have the auth-form on the page all the time, even when logged in (for relogging in purposes). This means the auth-form will not always be removed from the DOM when you log in. This sets the form back to its idle state before calling onsubmit * ui: Make a public api for modal-dialog with a single close method * ui : Move cache reset somewhere that makes more sense, + single refresh 1. Centralize cache resetting elsewhere, for now the store makes most sense, although I would prefer the Repository class, so using the store is temporary 2. We only need to refresh on login once, unless we have a differing nspace * ui: Ensure visibilitychange events are cleaned up * ui: Only cache DataSource data if we have any, + only clear the cache * ui: Add the modal login dialog to both unauth and auth views This means we can 'relogin' when already logged in * ui: Add new empty states * ui: CSS Tweaks * Remove marketing grays
This PR adds a bunch of new 'Empty States' to the UI e.g.
As the empty state lets you 'relogin' without logging out first, we change the login form slightly to enable it to appear even if you are in a logged in state.