-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent Auto Configuration: Configuration Syntax Updates #8003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2938351
to
243348f
Compare
3cf7e5b
to
881ef6e
Compare
243348f
to
dfe90f3
Compare
881ef6e
to
7daf838
Compare
dfe90f3
to
ce40ebb
Compare
97a121d
to
26fcbd1
Compare
26fcbd1
to
4fede2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the test failures look like there's some missing test changes.
ce40ebb
to
1ad948a
Compare
e9cd603
to
360b2e1
Compare
1ad948a
to
937deb7
Compare
3597838
to
03fd0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read the docs for this feature, but this mostly makes sense to me. Left some thoughts/questions about the config
03fd0e7
to
97cd434
Compare
97cd434
to
59e6c4c
Compare
🍒✅ Cherry pick of commit 9f7b22a onto |
This is the second in a series of PRs to add the agent auto configuration capabilities.
This PR just adds the necessary configuration items and validation but does not go beyond that to actually use the feature. Future PRs will be based off this one and implement the actual usage.