Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent Auto Configuration: Configuration Syntax Updates #8003

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jun 2, 2020

This is the second in a series of PRs to add the agent auto configuration capabilities.

This PR just adds the necessary configuration items and validation but does not go beyond that to actually use the feature. Future PRs will be based off this one and implement the actual usage.

Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/template/hil.go Show resolved Hide resolved
@mkeeler mkeeler force-pushed the feature/acl-node-identity branch from 2938351 to 243348f Compare June 2, 2020 16:22
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch 2 times, most recently from 3cf7e5b to 881ef6e Compare June 2, 2020 16:29
@mkeeler mkeeler force-pushed the feature/acl-node-identity branch from 243348f to dfe90f3 Compare June 2, 2020 16:31
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch from 881ef6e to 7daf838 Compare June 2, 2020 16:36
@mkeeler mkeeler force-pushed the feature/acl-node-identity branch from dfe90f3 to ce40ebb Compare June 3, 2020 14:53
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch 2 times, most recently from 97a121d to 26fcbd1 Compare June 3, 2020 15:18
agent/config/config.go Outdated Show resolved Hide resolved
agent/config/config.go Outdated Show resolved Hide resolved
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch from 26fcbd1 to 4fede2b Compare June 3, 2020 16:00
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the test failures look like there's some missing test changes.

@mkeeler mkeeler force-pushed the feature/acl-node-identity branch from ce40ebb to 1ad948a Compare June 3, 2020 16:41
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch 3 times, most recently from e9cd603 to 360b2e1 Compare June 3, 2020 18:32
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch 2 times, most recently from 3597838 to 03fd0e7 Compare June 11, 2020 13:45
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the docs for this feature, but this mostly makes sense to me. Left some thoughts/questions about the config

lib/template/hil.go Show resolved Hide resolved
agent/config/config.go Show resolved Hide resolved
agent/config/runtime.go Show resolved Hide resolved
agent/config/builder.go Outdated Show resolved Hide resolved
agent/config/builder.go Outdated Show resolved Hide resolved
Base automatically changed from feature/acl-node-identity to master June 16, 2020 16:54
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch from 03fd0e7 to 97cd434 Compare June 16, 2020 18:10
@mkeeler mkeeler force-pushed the feature/auto-config/configuration branch from 97cd434 to 59e6c4c Compare June 16, 2020 18:34
@mkeeler mkeeler merged commit 9f7b22a into master Jun 16, 2020
@mkeeler mkeeler deleted the feature/auto-config/configuration branch June 16, 2020 19:03
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 9f7b22a onto release/1.8.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants