ui: KV Form and List Components #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 20, 2020 09:37
johncowen
force-pushed
the
ui/chore/kv-form-list-components
branch
from
e67ce97
to
65ff8ba
Compare
|
🍒✅ Cherry pick of commit 5a5f87e onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jul 20, 2020
* Add components for KV form, KV list and Session form * Pass through a @Label attribute for a human label + don't require error * Ignore transition aborted errors for if you are re-transitioning * Make old confirmation dialog more ember-like and tagless * Make sure data-source and data-sink supports KV and sessions * Use new components and delete all the things * Fix up tests * Make list component tagless * Add component pageobject and fixup tests from that * Add eslint warning back in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8219 we made some additions to allow us to move away from mixin/inheritance based form and 'CRUD write actions'. We initially used these in our Intentions Forms and Lists that we use in various areas of the UI, at the same time we used KV to ensure that the components would be re-usable but didn't finish these up and PR them
This PR uses these same components for the KV section of the UI.
Additions:
<ConsulKvForm /><ConsulKvList /><ConsulSessionForm />The majority of the work involves making the new component and dropping the old partial into the body of a
<DataForm />component. As a result we were able to remove another 4 Controllers, 1 Route, 1 Mixin and 2 partials, plus their tests plus a bit more red change here and there.Notes:
<ConsulSessionForm />is needed for being able to 'invalidate a session' from a key value which is just using the 'delete' action from its<DataForm />(we can also use this now in our Node > Session Listing, for a future PR)<ConfirmationDialog />, which is probably from the very start of the UI, to make it much more 'ember-y' - a small note here, these confirmations are due to be completely replaced at some point.pageobjectfile for the<ConsulKvList />component for testing and moved the delete acceptance testing our of the top-level looping delete feature file into its own delete feature file within the kv folder.-test.jssuffix, so it wasn't being run, this file was just a placeholder file anyway (the tests inside were skipped for the moment), so I just deleted this file while I was here.Controller.setPropertiesin order to convert our data into changesets - this converting/wrapping is now done in the<DataForm />instead of overwriting a common ember method.