Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoConfig implies Connect #8433

Merged
merged 1 commit into from
Aug 7, 2020
Merged

AutoConfig implies Connect #8433

merged 1 commit into from
Aug 7, 2020

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Aug 5, 2020 •
edited
Loading

This PR turns on connect when using auto_config.

  • add tests
  • update docs

mkeeler
mkeeler reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but it could use a test to ensure connect gets enabled if auto config is.

@hanshasselberg hanshasselberg merged commit d316cd0 into master Aug 7, 2020
@hanshasselberg hanshasselberg deleted the auto_config branch August 7, 2020 10:02
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d316cd0 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Aug 7, 2020
@hanshasselberg @hashicorp-ci
auto_config implies connect (#8433)
ba495cd
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanshasselberg @hashicorp-ci @mkeeler