agent/consul: make Client/Server config reloading more obvious #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
added
theme/internal-cleanup
15 tasks
dnephin
force-pushed
the
dnephin/fix-load-limits
branch
2 times, most recently
from
8c1189d
to
d2afe6d
Compare
I believe this commit also fixes a bug. Previously RPCMaxConnsPerClient was not being re-read from the RuntimeConfig, so passing it to Server.ReloadConfig was never changing the value. Also improve the test runtime by not doing a lot of unnecessary work.
so that the field name is consistent across config structs.
dnephin
force-pushed
the
dnephin/fix-load-limits
branch
from
d2afe6d
to
e66af1a
Compare
|
Added a changelog entry for the bug fix, and confirmed the test failures are flakes that pass locally. |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/310796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not clear which fields were being reloaded. They were hidden in multiple function calls and large structs. With this change the list of reloadable fields is explicit.
I believe this commit also fixes a bug. Previously
RPCMaxConnsPerClientwas not being re-read from the RuntimeConfig, so passing it to Server.ReloadConfig was never changing the value.Also improve the test runtime by not doing a lot of unnecessary work, and fixed the naming of one of the config fields so that it is consistent across structs.