Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestLeader_SecondaryCA_IntermediateRenew #8702

Merged
merged 5 commits into from
Sep 18, 2020
Merged

fix TestLeader_SecondaryCA_IntermediateRenew #8702

merged 5 commits into from
Sep 18, 2020

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Sep 17, 2020 •
edited
Loading

@freddygv and I investigated this infamous flaky test and we think we fixed it!

@hanshasselberg hanshasselberg changed the title fix lessThanHalfTime fix TestLeader_SecondaryCA_IntermediateRenew Sep 17, 2020
dnephin
dnephin approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for getting this fixed!

I think RBs suggestion for renaming the func to include WithLock or something like that would be good, but I also don't want to block getting this merged.

agent/structs/connect_ca.go Outdated Show resolved Hide resolved
mkeeler
mkeeler approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsosulska
Copy link
Contributor

Fixes #8686 and #7520

@hanshasselberg hanshasselberg merged commit d4877f0 into master Sep 18, 2020
@hanshasselberg hanshasselberg deleted the fix_secondary_renew_flake branch September 18, 2020 08:13
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d4877f0 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 18, 2020
@hanshasselberg @hashicorp-ci
fix TestLeader_SecondaryCA_IntermediateRenew (#8702)
abd8e60 
* fix lessThanHalfTime
* get lock for CAProvider()
* make a var to relate both vars
* rename to getCAProviderWithLock
* move CertificateTimeDriftBuffer to agent/connect/ca
@dnephin dnephin mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer left review comments

@dnephin dnephin dnephin approved these changes

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hanshasselberg @jsosulska @hashicorp-ci @rboyer @dnephin @mkeeler @hashibot-web