Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: prune logs on startup #9012

Merged
merged 3 commits into from Nov 23, 2020
Merged

logging: prune logs on startup #9012

merged 3 commits into from Nov 23, 2020

Commits on Nov 21, 2020

  1. logging: remove unnecessary package vars

    @dnephin
    dnephin committed Nov 21, 2020
    Copy the full SHA
    b847c03 View commit details
    Browse the repository at this point in the history

  2. logging: call pruneFiles on startup 

    To ensure that files are pruned before a new one is created.

Also clean up the logic in pruneFiles
    @dnephin
    dnephin committed Nov 21, 2020
    Copy the full SHA
    2dcc696 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. logging: improve tests 

    Standardize naming
Use stricter assertions and reduce boilerplate to make the intent of the tests more obvious.

Also explicitly sort the filenames so that the correct files are pruned,
and so that the tests can not flake.
    @dnephin
    dnephin committed Nov 23, 2020
    Copy the full SHA
    752e3ec View commit details
    Browse the repository at this point in the history