New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: only try to create an ipv6 expose checks listener if ipv6 is supported by the kernel #9765
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0f773f8
xds: only try to create an ipv6 expose checks listener if ipv6 is sup…
rboyer 3f99085
add in an envoy integration test for exposed checks
rboyer 564eb23
also add an envoy golden test for expose checks
rboyer b3da076
remove debugging tool
rboyer d76a291
changelog
rboyer File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// +build !linux | ||
|
||
package xds | ||
|
||
func kernelSupportsIPv6() (bool, error) { | ||
return true, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// +build linux | ||
|
||
package xds | ||
|
||
import ( | ||
"fmt" | ||
"os" | ||
"sync" | ||
) | ||
|
||
const ipv6SupportProcFile = "/proc/net/if_inet6" | ||
|
||
var ( | ||
ipv6SupportOnce sync.Once | ||
ipv6Supported bool | ||
ipv6SupportedErr error | ||
) | ||
|
||
func kernelSupportsIPv6() (bool, error) { | ||
ipv6SupportOnce.Do(func() { | ||
ipv6Supported, ipv6SupportedErr = checkIfKernelSupportsIPv6() | ||
}) | ||
return ipv6Supported, ipv6SupportedErr | ||
} | ||
|
||
func checkIfKernelSupportsIPv6() (bool, error) { | ||
_, err := os.Stat(ipv6SupportProcFile) | ||
if os.IsNotExist(err) { | ||
return false, nil | ||
} else if err != nil { | ||
return false, fmt.Errorf("error checking for ipv6 support file %s: %w", ipv6SupportProcFile, err) | ||
} | ||
|
||
return true, nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rboyer and I had a chat about testing; it's kind of thorny. Mocking this gets us into trouble with parallel unit tests, as we risk changing an invariant under other tests noses.