Embed hashicorp/addLicense fork #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaguerta
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Previously, we maintained a fork of
google/addlicensehere in order to make it easier to customize while still being able to pull updates downstream. Given the increasing frequency in which changes need to be made to the fork, I've found us frequently making changes to the fork, creating a new release there, and then creating a subsequent PR in this repo to pull the latest improvements in.To simplify the dependency management, I propose we just pull the fork into this repo and deprecate/archive the old one. This will allow us to iterate faster, especially as our fork and the upstream project have been on a path of divergence. I'd still like to make efforts to cherry pick changes upstream whenever something we change can benefit the larger community, however.
🔗 External Links
👍 Definition of Done
🤔 Can be merged upon approval?
✅