Address deprecated goreleaser configuration #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaguerta
requested review from
a team,
modrake and
claire-labry
and removed request for
a team
dekimsey
added a commit
that referenced
this pull request
Sep 28, 2023
actions/setup-copywrite relies on the [specific name](https://github.com/hashicorp/setup-copywrite/blob/main/action.js#L65) format. Note: the `s/amd64/x86_64/g` behavior is a historical artifact, we could update it in the future if we coordinate with the action. Error: ``` Run hashicorp/setup-copywrite@867a1a2 Error: Unable to find asset matching copywrite_0.16.5_linux_x86_64.tar.gz in the v0.16.5 release ``` After this change: ``` • archives • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_windows_x86_64.zip • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_linux_x86_64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_darwin_x86_64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_darwin_arm64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_linux_arm64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_windows_arm64.zip ``` Partial revert of changes made in PR #98 nit: Also adding `dist/` to our ignores
2 tasks
dekimsey
added a commit
that referenced
this pull request
Sep 28, 2023
actions/setup-copywrite relies on the [specific name](https://github.com/hashicorp/setup-copywrite/blob/main/action.js#L65) format. Note: the `s/amd64/x86_64/g` behavior is a historical artifact, we could update it in the future if we coordinate with the action. Error: ``` Run hashicorp/setup-copywrite@867a1a2 Error: Unable to find asset matching copywrite_0.16.5_linux_x86_64.tar.gz in the v0.16.5 release ``` After this change: ``` • archives • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_windows_x86_64.zip • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_linux_x86_64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_darwin_x86_64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_darwin_arm64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_linux_arm64.tar.gz • creating archive=dist/copywrite_0.16.5-SNAPSHOT-52379d7_windows_arm64.zip ``` Partial revert of changes made in PR #98 nit: Also adding `dist/` to our ignores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
recent updates from goreleaser made parts of our
.goreleaser.yamlinvalid. These changes address the deprecations found in https://goreleaser.com/deprecations/#brewstap, and will get our build and release pipeline back to green.🔗 External Links
👍 Definition of Done
🤔 Can be merged upon approval?
✅