Apply suggestions from code review

Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
hashicorp · May 23, 2024 · 74d3466 · 74d3466
1 parent 7867b95
commit 74d3466
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/components/src/components/hds/copy/snippet/index.hbs b/packages/components/src/components/hds/copy/snippet/index.hbs
@@ -10,7 +10,7 @@
   ...attributes
 >
   <Hds::Text::Code class="hds-copy-snippet__text" @tag="span" @size="100">
-    {{this.textToCopy}}
+    {{this.textToShow}}
   </Hds::Text::Code>
   <FlightIcon @name={{this.icon}} class="hds-copy-snippet__icon" />
 </button>
diff --git a/packages/components/src/components/hds/copy/snippet/index.ts b/packages/components/src/components/hds/copy/snippet/index.ts
@@ -23,10 +23,10 @@ interface HdsCopySnippetSignature {
   Args: {
     color?: HdsCopySnippetColors;
     isFullWidth?: boolean;
+    textToCopy: HdsClipboardModifierSignature['Args']['Named']['text'];
     isTruncated?: boolean;
-    onError?: HdsClipboardModifierSignature['Args']['Named']['onError'];
     onSuccess?: HdsClipboardModifierSignature['Args']['Named']['onSuccess'];
-    textToCopy: HdsClipboardModifierSignature['Args']['Named']['text'];
+    onError?: HdsClipboardModifierSignature['Args']['Named']['onError'];
   };
   Element: HTMLButtonElement;
 }
@@ -39,7 +39,7 @@ export default class HdsCopySnippetComponent extends Component<HdsCopySnippetSig
    * @param textToCopy
    * @type {string | number | bigint | undefined} ???
    */
-  get textToCopy() {
+  get textToShow() {
     const { textToCopy = '' } = this.args;
 
     if (typeof textToCopy === 'string') {
@@ -132,8 +132,7 @@ export default class HdsCopySnippetComponent extends Component<HdsCopySnippetSig
   }
 
   @action
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  onSuccess(args: any) {
+  onSuccess(args: HdsClipboardModifierSignature['Args']['Named']['onSuccess']) {
     this.status = 'success';
     this.resetStatusDelayed();
 
@@ -145,8 +144,7 @@ export default class HdsCopySnippetComponent extends Component<HdsCopySnippetSig
   }
 
   @action
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  onError(args: any) {
+  onError(args: HdsClipboardModifierSignature['Args']['Named']['onError']) {
     this.status = 'error';
     this.resetStatusDelayed();