Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SideNav component - Add component-specific design tokens #1313

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Apr 20, 2023

๐Ÿ“Œ Summary

As a follow-up of #1163 and #1304, we want to add component-specific design tokens for the SideNav component.

๐Ÿ› ๏ธ Detailed description

In this PR I have:

  • added design tokens for SideNav component
  • regenerated design tokens in output
  • removed the old CSS variables for SideNav and replaced them with new design tokens

๐Ÿ”— External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-1696


๐Ÿ‘€ How to review

Reviewer's checklist:

  • Confirm that PR has a changelog update via Changesets if needed

๐Ÿ’ฌ Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
hds-showcase โœ… Ready (Inspect) Visit Preview Apr 20, 2023 11:02am
hds-website โœ… Ready (Inspect) Visit Preview Apr 20, 2023 11:02am

@didoo didoo merged commit 7446efc into main Apr 21, 2023
@didoo didoo deleted the sidenav-design-tokens branch April 21, 2023 07:33
@hashibot-hds hashibot-hds mentioned this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants