Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Separator component #1393

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Add Separator component #1393

merged 5 commits into from
Jun 13, 2023

Conversation

alex-ju
Copy link
Member

@alex-ju alex-ju commented Jun 1, 2023 •
edited
Loading

📌 Summary

Add Separator component.

🛠️ Detailed description

The Separator component, as currently designed, has a default value for spacing and allows for no spacing.

The proposed implementation accounts for potentially adding new values for spacing in the future (aside from default and none 24 and 0) that could seem like over-engineering at this point.

🔗 External links

Jira ticket: HDS-1957
Figma file: https://www.figma.com/file/AtpgpJnBiTjZ0kMyaf016J/ag%2FSeparator-Component?type=design&node-id=35993-73604&t=PEzHe2gngwAX6jUv-4

👀 Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Jun 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jun 13, 2023 10:55am
hds-website ✅ Ready (Inspect) Visit Preview Jun 13, 2023 10:55am

@alex-ju alex-ju marked this pull request as ready for review June 5, 2023 13:33
@alex-ju alex-ju requested review from andgen404 and a team June 5, 2023 13:34
didoo
didoo approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

andgen404
andgen404 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@andgen404 andgen404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jun 13, 2023
@alex-ju alex-ju force-pushed the alex-ju/add-separator-component branch from 7be7508 to 31c45bd Compare June 13, 2023 10:27
alex-ju and others added 3 commits June 13, 2023 11:51
@alex-ju
Switch @spacing to numerical values
23c3135
@alex-ju @andgen404
@MelSumner @heatherlarsen @didoo
Add Separator docs (#1398)
dfef4e1 
Co-authored-by: Andrew Gendel <124841193+andgen404@users.noreply.github.com>
Co-authored-by: Melanie Sumner <melanie@hashicorp.com>
Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
@alex-ju
Fix order after rebase
d3a9db1
@alex-ju alex-ju force-pushed the alex-ju/add-separator-component branch from 31c45bd to d3a9db1 Compare June 13, 2023 10:51
@alex-ju alex-ju merged commit 084bdeb into main Jun 13, 2023
8 checks passed
@alex-ju alex-ju deleted the alex-ju/add-separator-component branch June 13, 2023 10:58
@hashibot-hds hashibot-hds mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaulagiri Dhaulagiri Dhaulagiri left review comments

@didoo didoo didoo approved these changes

@andgen404 andgen404 andgen404 approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alex-ju @didoo @Dhaulagiri @andgen404 @hashibot-hds