IconTile - Add "Vault Secrets" product
#1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
force-pushed
the
add-vault-secrets-to-icon-tile
branch
from
e8254d7
to
344c86a
Compare
didoo
force-pushed
the
add-vault-secrets-to-icon-tile
branch
from
344c86a
to
12498e3
Compare
Dhaulagiri
approved these changes
Sep 15, 2023
|
@didoo It looks like the Component API needs to be updated in the docs unless you want to handle documentation changes in a different PR? |
Good catch! Didn't realize the products are listed in the |
|
@heatherlarsen OK, pushed the changes |
hashibot-hds
added
docs-website
didoo
force-pushed
the
add-vault-secrets-to-icon-tile
branch
from
50ab5dc
to
b161f22
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is the counterpart of the work done in design to add the "Vault Secrets" product option to the
IconTilecomponent.🛠️ Detailed description
In this PR I have:
design tokens
components
IconTilecode to includevault-secretsIconTileshowcaseIconTile👉 👉 👉 Preview: https://hds-showcase-git-add-vault-secrets-to-icon-tile-hashicorp.vercel.app/components/icon-tile
📸 Screenshots
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-2517
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.