Update SideNav guidelines, anatomy, docs #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
jorytindall
changed the title
alex-ju
force-pushed
the
sidenav-doc-updates
branch
from
812105f
to
0d42703
Compare
website/docs/components/side-nav/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/side-nav/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
KristinLBradley
approved these changes
Sep 25, 2023
7 tasks
didoo
requested changes
Sep 25, 2023
website/docs/components/side-nav/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/public/assets/components/side-nav/sidenav-overlay-small-viewport.png
Outdated
Show resolved
Hide resolved
website/docs/components/side-nav/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
didoo
approved these changes
Sep 28, 2023
website/docs/components/side-nav/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
alex-ju
force-pushed
the
alex-ju/collapsable-sidenav
branch
from
c01c99d
to
97712d3
Compare
alex-ju
force-pushed
the
sidenav-doc-updates
branch
from
6dcb526
to
14e7bb3
Compare
alex-ju
force-pushed
the
sidenav-doc-updates
branch
from
14e7bb3
to
a35051f
Compare
…s.md Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
…s.md Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
alex-ju
force-pushed
the
sidenav-doc-updates
branch
from
a35051f
to
63b558e
Compare
alex-ju
pushed a commit
that referenced
this pull request
Oct 2, 2023
alex-ju
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged this PR will update the documentation for the
SideNavto include content around the collapse functionality and update relevant imagery with the added trigger button.🔗 External links
Jira ticket: HDS-2495
Figma file: SideNav component
💬 Please consider using conventional comments when reviewing this PR.