Fix pre-build script invocation + Update release notes
#1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
reviewed
Oct 25, 2023
| "prebuild": "node lib/changelog/generate-changelog-markdown-files.mjs", | ||
| "build": "ember build --environment=production", | ||
| "generate-changelog-markdown-files": "node lib/changelog/generate-changelog-markdown-files.mjs", | ||
| "build": "yarn generate-changelog-markdown-files && ember build --environment=production", |
There was a problem hiding this comment.
I'm curious the thinking of including this in the build as well: is this a workaround for the fact that prebuild doesn't actually do anything? If we are updating this as part of the version step I think this would not actually ever trigger new changes. Am I thinking about that correctly?
There was a problem hiding this comment.
it's just in case, until we find out if the yarn version works, then we can remove it
Dhaulagiri
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Context:
Upon investigation, we have found that
yarndoes not execute thepre/postscripts automatically:See: yarnpkg/yarn#800
From the Yarn documentation:
🛠️ Detailed description
In this PR I have:
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.