add static svg sprite sheet file #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
alex-ju
approved these changes
Nov 3, 2023
MelSumner
approved these changes
Nov 3, 2023
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR adds support for a plain SVG sprite sheet (in addition to the existing JavaScript module version).
🛠️ Detailed description
In order to support using the SVG sprite sheet in our Next.js websites without shipping the sprite sheet as several hundred kilobytes of JavaScript, we'd like to simply reference an SVG file. This PR outputs the generated SVG sprite sheet to an SVG file in addition to the existing JS module. Two attributes were added to the root
<svg>element for maximum compatibility:xmlns="http://www.w3.org/2000/svg"Some browsers will not correctly render remote<use>references unless the remote document has the correct namespace.viewBox="0 0 0 0"Next.js expects there to be aviewBoxattribute to calculate dimensions. While this isn't actually useful in this case, it does prevent Next.js from throwing an error about being unable to parse the file.Neither of these changes should have any impact on existing usage, hence the
minorversion bump.📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
yarn test:a11y --filter="COMPONENT-NAME")a11yAudithas been added💬 Please consider using conventional comments when reviewing this PR.