Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppFooter::StatusLink: Fix predefined statuses—replace "critical" with "outage" (HDS-2854) #1790

Merged
merged 3 commits into from Nov 10, 2023
Merged

AppFooter::StatusLink: Fix predefined statuses—replace "critical" with "outage" (HDS-2854) #1790

merged 3 commits into from Nov 10, 2023

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Nov 8, 2023 •
edited by alex-ju

📌 Summary

If merged, this PR will:

  • Fix status name to align with Cloud-ui—replace "critical" with "outage"
  • Fix issue with custom icon color being overridden by pre-set status colors
  • Cleanup old unused code related to icon color

🔗 External links

👀 Component checklist

  • Percy was checked for any visual regression
  • A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME")
  • If documenting a new component, an acceptance test that includes the a11yAudit has been added
  • A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 10, 2023 11:21am
hds-website ✅ Ready (Inspect) Visit Preview Nov 10, 2023 11:21am

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website labels Nov 8, 2023
alex-ju
alex-ju approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – I've tested it in the cloud-ui branch as well. Don't forget the changelog entry before getting it in.

packages/components/addon/components/hds/app-footer/status-link.js Outdated Show resolved Hide resolved
@KristinLBradley @alex-ju
Update packages/components/addon/components/hds/app-footer/status-lin…
43f6962 
…k.js

Co-authored-by: Alex <alex-ju@users.noreply.github.com>
@KristinLBradley KristinLBradley changed the title AppFooter::StatusLink: Rename critical status to outage (HDS-2854) AppFooter::StatusLink: Fix predefined statuses—replace "critical" with "outage" (HDS-2854) Nov 9, 2023
@KristinLBradley KristinLBradley marked this pull request as ready for review November 9, 2023 17:32
@KristinLBradley KristinLBradley requested review from didoo and a team November 9, 2023 17:33
@KristinLBradley
Copy link
Contributor Author

@didoo If you have time to review, I'd appreciate it.

didoo
didoo approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alex-ju alex-ju force-pushed the hds-2854-appfooter-statuslink-change-critical-status-to-outage branch from 899b7b5 to ca34117 Compare November 10, 2023 11:17
@alex-ju alex-ju merged commit bdcc216 into main Nov 10, 2023
6 of 8 checks passed
@alex-ju alex-ju deleted the hds-2854-appfooter-statuslink-change-critical-status-to-outage branch November 10, 2023 11:17
@hashibot-hds hashibot-hds mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@didoo didoo didoo approved these changes

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KristinLBradley @didoo @alex-ju @MelSumner @hashibot-hds