Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBlock: Add Ruby language support (HDS-2926) #1834

Merged
merged 3 commits into from
Nov 27, 2023
Merged

CodeBlock: Add Ruby language support (HDS-2926) #1834

merged 3 commits into from
Nov 27, 2023

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Nov 27, 2023 •
edited by jira bot
Loading

📌 Summary

If merged, this PR will add Ruby language support to the CodeBlock component.

🔗 External links

Jira ticket: HDS-2926

👀 Component checklist

  • Percy was checked for any visual regression
  • A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME")
  • If documenting a new component, an acceptance test that includes the a11yAudit has been added
  • A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 27, 2023 7:35pm
hds-website ✅ Ready (Inspect) Visit Preview Nov 27, 2023 7:35pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website labels Nov 27, 2023
@KristinLBradley KristinLBradley marked this pull request as ready for review November 27, 2023 19:05
KristinLBradley
KristinLBradley commented Nov 27, 2023
View reviewed changes
.changeset/friendly-hounds-jog.md
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this should be just a patch instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, feature feels appropriate

@KristinLBradley KristinLBradley requested a review from a team November 27, 2023 19:06
@DingoEatingFuzz
Copy link
Contributor

Amazingly fast turnaround on this ❤️

alex-ju
alex-ju approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up so quickly, @KristinLBradley! 🚀

packages/components/addon/components/hds/code-block/index.js Outdated Show resolved Hide resolved
.changeset/friendly-hounds-jog.md
@@ -0,0 +1,5 @@
---
"@hashicorp/design-system-components": minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, feature feels appropriate

@KristinLBradley @alex-ju
Update packages/components/addon/components/hds/code-block/index.js
3117370 
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
MelSumner
MelSumner approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KristinLBradley KristinLBradley merged commit 325a3c2 into main Nov 27, 2023
4 checks passed
@KristinLBradley KristinLBradley deleted the hds-2926-add-codeblock-ruby-support branch November 27, 2023 21:40
@hashibot-hds hashibot-hds mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-ju alex-ju alex-ju approved these changes

@MelSumner MelSumner MelSumner approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KristinLBradley @DingoEatingFuzz @alex-ju @MelSumner @hashibot-hds