Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Add isInline argument (HDS-2681) #1854

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Button: Add isInline argument (HDS-2681) #1854

merged 6 commits into from
Dec 5, 2023

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Dec 5, 2023 •
edited
Loading

📌 Summary

If merged, this PR adds the @isInline argument to the Button component.

🔗 External links

👀 Component checklist

  • Percy was checked for any visual regression
  • A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME") - I ran this and am seeing a bunch of failed tests but they seem unrelated to my changes.
  • If documenting a new component, an acceptance test that includes the a11yAudit has been added
  • A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

@KristinLBradley
HDS-2681 Add isInline argument to Button along with examples, fix min…
ba5b98d 
…or grammatical and punctuation errors in Dropdown isInline docs for consistency
@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 5, 2023 7:32pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 5, 2023 7:32pm

@hashibot-hds hashibot-hds added packages/components docs-website Content updates to the documentation website labels Dec 5, 2023
@KristinLBradley KristinLBradley requested review from a team December 5, 2023 00:28
didoo
didoo reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KristinLBradley left a few comments.

packages/components/tests/dummy/app/templates/components/button.hbs Show resolved Hide resolved
website/docs/components/button/partials/code/how-to-use.md Show resolved Hide resolved
packages/components/app/styles/components/button.scss Outdated Show resolved Hide resolved
didoo
didoo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

website/docs/components/button/partials/code/how-to-use.md Outdated Show resolved Hide resolved
website/docs/components/button/partials/code/how-to-use.md Outdated Show resolved Hide resolved
KristinLBradley and others added 2 commits December 5, 2023 11:23
@KristinLBradley
HDS-2681 Delete commented out content
9bfca41
@KristinLBradley @didoo
Apply suggestions from code review
061152a 
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
@KristinLBradley KristinLBradley merged commit 2ab2d55 into main Dec 5, 2023
15 checks passed
@KristinLBradley KristinLBradley deleted the hds-2681-button-add-isinline branch December 5, 2023 19:34
@hashibot-hds hashibot-hds mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo approved these changes

@heatherlarsen heatherlarsen heatherlarsen approved these changes

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KristinLBradley @didoo @heatherlarsen @hashibot-hds