-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppFooter
: Change visual alignment to centered (HDS-2960)
#1867
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AppFooter
: Change visual alignment from right to centered (HDS-2960)AppFooter
: Change visual alignment to centered (HDS-2960)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from the code side. But before merging:
- wait for the equivalent change in Figma to be ready to be released
- wait for the images in the documentation to be updated too (could be done in this PR, or in a separate one)
…to simplify linking to specific sections
Add extra headings to character count documentation
Added screenshots showing the One issue, their old footer a property for UPDATE: For now I did this
Related Slack thread: https://hashicorp.slack.com/archives/C03JP1TCGQM/p1702948434832399?thread_ts=1700519716.692309&cid=C03JP1TCGQM |
@KristinLBradley probably I would work/collaborate with them to find the correct solution (they have better context of their codebase) |
Co-authored-by: heatherlarsen <heatherlarsen@users.noreply.github.com> Co-authored-by: heatherlarsen <hlarsen@hashicorp.com>
…th the CopyButton and input controls
`Tooltip` - Fix text alignment
Add compositional recommendations to the CopyButton docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me 🎉
Documentation has been updated with new images & Figma component updates from @andgen404 are ready to go. |
📌 Summary
If merged, this PR changes the
AppFooter
visual alignment from right-aligned to centered.📸 Screenshots
TFC - BEFORE (with old footer):
TFC - AFTER (with Hds::AppFooter):
🔗 External links
👀 Component checklist
A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME"
)If documenting a new component, an acceptance test that includes thea11yAudit
has been added💬 Please consider using conventional comments when reviewing this PR.