Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppFooter: Change visual alignment to centered (HDS-2960) #1867

Merged
merged 25 commits into from
Dec 20, 2023

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Dec 13, 2023

📌 Summary

If merged, this PR changes the AppFooter visual alignment from right-aligned to centered.

📸 Screenshots

TFC - BEFORE (with old footer):
Before_TFC-footer

TFC - AFTER (with Hds::AppFooter):
After_TFC-HdsAppFooter

🔗 External links


👀 Component checklist

  • Percy was checked for any visual regression
  • A11y tests have been run locally (yarn test:a11y --filter="COMPONENT-NAME")
  • If documenting a new component, an acceptance test that includes the a11yAudit has been added
  • A changelog entry was added via Changesets if needed (see templates here)

💬 Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Dec 20, 2023 7:59pm
hds-website ✅ Ready (Inspect) Visit Preview Dec 20, 2023 7:59pm

@KristinLBradley KristinLBradley changed the title AppFooter: Change visual alignment from right to centered (HDS-2960) AppFooter: Change visual alignment to centered (HDS-2960) Dec 13, 2023
@KristinLBradley KristinLBradley requested review from a team December 13, 2023 19:52
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from the code side. But before merging:

  • wait for the equivalent change in Figma to be ready to be released
  • wait for the images in the documentation to be updated too (could be done in this PR, or in a separate one)

@KristinLBradley
Copy link
Contributor Author

KristinLBradley commented Dec 14, 2023

Added screenshots showing the Hds::AppFooter within TFC.

One issue, their old footer a property for this.currentOrganization as part of their "Support" link href. Not sure where I would put that so it works with the Hds::AppFooter. I'd have to create a new JavaScript file.

UPDATE: For now I did this

  • @hrefForSupport={{if @currentOrganization (support-email-link @currentOrganization) null}}
  • Opened a PR using wrapper component.

Related Slack thread: https://hashicorp.slack.com/archives/C03JP1TCGQM/p1702948434832399?thread_ts=1700519716.692309&cid=C03JP1TCGQM

@didoo
Copy link
Contributor

didoo commented Dec 15, 2023

One issue, their old footer a property for this.currentOrganization as part of their "Support" link href. Not sure where I would put that so it works with the Hds::AppFooter. I'd have to create a new JavaScript file.

UPDATE: For now I did this @hrefForSupport={{if @currentOrganization (support-email-link @currentOrganization) null}}

@KristinLBradley probably I would work/collaborate with them to find the correct solution (they have better context of their codebase)

Copy link
Contributor

@andgen404 andgen404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 🎉

@KristinLBradley
Copy link
Contributor Author

All good from the code side. But before merging:

  • wait for the equivalent change in Figma to be ready to be released
  • wait for the images in the documentation to be updated too (could be done in this PR, or in a separate one)

Documentation has been updated with new images & Figma component updates from @andgen404 are ready to go.

@KristinLBradley KristinLBradley requested review from a team December 20, 2023 21:13
@KristinLBradley KristinLBradley merged commit d5407e5 into main Dec 20, 2023
15 checks passed
@KristinLBradley KristinLBradley deleted the hds-2960-app-footer-alignment branch December 20, 2023 21:20
@hashibot-hds hashibot-hds mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components packages/flight-icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants