Tabs - Fix subcomponents' backing-class names
#1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Fix the backing-class names for
Tabssubcomponents (PanelandTab).🛠️ Detailed description
While these currently do not seem to have much of an impact on consumers (other than them not being able to import or extend these subcomponents) it does create issues in the v2 addon world.
🔗 External links
Jira ticket: HDS-2875
👀 Component checklist
yarn test:a11y --filter="COMPONENT-NAME")a11yAudithas been added💬 Please consider using conventional comments when reviewing this PR.