-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename namespaced contextual components #1884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me 👍
Question: should we provide also a codemod for the consumers?
Saw your message in Slack. Let me know when the codemod is added so I can review it as well
…ate::Footer::LinkStandalone`
2e3fb49
to
4ebf4e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Rename namespaced contextual components as follows:
Alert::Link::Standalone
toAlert::LinkStandalone
ApplicationState::Footer::Link::Standalone
toApplicationState::Footer::LinkStandalone
Form::Checkbox::Group::Checkbox::Field
toCheckbox::Group::CheckboxField
Form::Radio::Group::Radio::Field
toForm::Radio::Group::RadioField
Form::Toggle::Group::Toggle::Field
toForm::Toggle::Group::ToggleField
Toast::Link::Standalone
toToast::LinkStandalone
The new names are more idiomatic, will align these instances with other subcomponents, and provide a smooth path when imported to
gts
.Note: As this is a major change, we'll try to add codemods in this PR to help with migrating to the new format.
🔗 External links
Jira ticket: HDS-2972
👀 Component checklist
yarn test:a11y --filter="COMPONENT-NAME"
)a11yAudit
has been added💬 Please consider using conventional comments when reviewing this PR.