Update shell-session default color
#1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
didoo
approved these changes
Jan 19, 2024
| @@ -50,7 +50,7 @@ | |||
|
|
|||
| // Syntax highlighting tokens: | |||
| // general ---- | |||
| --hds-code-block-color-token: var(--hds-code-block-color-green); | |||
| --hds-code-block-color-token: var(--hds-code-block-color-foreground-primary); | |||
|
I commented within the Figma file and within Jory's Slack thread |
KristinLBradley
approved these changes
Jan 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is a draft PR to capture some of the different examples referenced in these Figma mockups around syntax highlighting for shell-session examples and bash examples.
Can be trashed, this is meant to be more representative.
🔗 External links
Jira ticket: HDS-2949
Figma file: CodeBlock Color Updates
👀 Component checklist
yarn test:a11y --filter="COMPONENT-NAME")a11yAudithas been added💬 Please consider using conventional comments when reviewing this PR.