Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated export of icons from Figma #1986

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Updated export of icons from Figma #1986

merged 4 commits into from
Mar 12, 2024

Conversation

hashibot-hds
Copy link
Collaborator

@hashibot-hds hashibot-hds commented Mar 11, 2024

📌 Summary

Adding an updated category list to the icon library for the Helios website. In the JSON package, "Category" will accompany the new category name for all icons.

🔗 External links

Jira ticket: HDS-2094
Figma file: Flight Library


👀 Component checklist

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Mar 12, 2024 4:43pm
hds-website ✅ Ready (Inspect) Visit Preview Mar 12, 2024 4:43pm

"@hashicorp/flight-icons": minor
---

This PR introduces upates to the category names in the Flight library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use language like "This PR introduces..." in the changesets. What about something more descriptive, like:

Reorganized the icons within the "Core" icon set into 16 more descriptive categories.

Note our Changelog content best practices: https://github.com/hashicorp/design-system/blob/main/wiki/Website-Changelog.md#content-formatting

Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
@andgen404 andgen404 merged commit 933149a into main Mar 12, 2024
16 checks passed
@andgen404 andgen404 deleted the hds-icon-export-ce7eb65 branch March 12, 2024 18:47
@hashibot-hds hashibot-hds mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants