-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge
- Convert to TypeScript
#1991
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🙌 🙌 could we remove the glint-nocheck
in the template too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I've just added very minor thing to take a look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, mainly for internal discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a bunch of comments, but since I see differences between the conversion of this component in comparison with the previous ones, is better to wait for @alex-ju to come back from PTO (he has more context and knowledge)
@WenInCode see my comment above
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for getting this to the finish line @WenInCode! there are a few changes before we can get this merged, but let me know if you don't have the time to address them and I can take it over
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Badge
- Convert to TypeScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and addressed the remaining feedback
📌 Summary
We love TypeScript! This PR converts the famous 🦡 component over to Typescript!
🛠️ Detailed description
With glint being enabled across the design-system - this PR converts a component over to Typescriptland!
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
References