Flyout: Add interpolation to Sass size variable (HDS-3206)
#1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
approved these changes
Mar 14, 2024
didoo
approved these changes
Mar 14, 2024
Co-authored-by: Alex <alex-ju@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds Sass interpolation to the
$sizevariable used to set the Flyout width and margin📸 Screenshots
BUG:.
Sass
$sizevariable appears in the inspected styles (meaning that it is broken since it should have been replaced with the pixel value):FIX:
🔗 External links
Jira ticket: HDS-3206
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.