Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card - Convert to TypeScript #1997

Merged
merged 6 commits into from Mar 20, 2024
Merged

Card - Convert to TypeScript #1997

merged 6 commits into from Mar 20, 2024

Conversation

valeriia-ruban
Copy link
Contributor

@valeriia-ruban valeriia-ruban commented Mar 14, 2024

πŸ“Œ Summary

Converts the following to TypeScript with glint-checked templates:

Hds::Card

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

πŸ”— External links

Jira ticket: HDS-2687
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Mar 19, 2024 8:56pm
hds-website βœ… Ready (Inspect) Visit Preview Mar 19, 2024 8:56pm

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've settled on a naming convention for what we define in types.ts I'll have to ask for a few renames, otherwise it looks great! πŸŽ‰

packages/components/src/components/hds/card/container.ts Outdated Show resolved Hide resolved
packages/components/src/template-registry.ts Outdated Show resolved Hide resolved
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! πŸ™Œ

@valeriia-ruban valeriia-ruban merged commit e1c6a7b into main Mar 20, 2024
16 checks passed
@valeriia-ruban valeriia-ruban deleted the ts-conversion-card branch March 20, 2024 19:27
@hashibot-hds hashibot-hds mentioned this pull request Mar 20, 2024
@alex-ju alex-ju changed the title TypeScript: Convert Hds::Card to TypeScript TypeScript - Hds::Card Mar 21, 2024
@alex-ju alex-ju changed the title TypeScript - Hds::Card Card - Convert to TypeScript May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants