-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-map class-name color token in CodeBlock #2027
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorytindall Looks good to me. Do you want to change this from a draft?
@KristinLBradley thanks for the quick review! Added a changeset as well. I don't think this requires any changes in design, the only thing I can think of is creating a parallel language variant in the Figma component for JavaScript (which we don't have), but I'll discuss in our design sync tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for the quick turn around, glad we were able to get this in so quickly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
@jorytindall This looks good to merge when you are ready. |
📌 Summary
Draft/Example PR. As far as I can tell, this change only affects our JavaScript examples in the showcase.
Showcase 👉 https://hds-showcase-git-jt-code-block-class-name-hashicorp.vercel.app/components/code-block#highlight-lines
📸 Screenshots
Before
![Screenshot 2024-03-26 at 12 24 01 PM](https://private-user-images.githubusercontent.com/2200899/317011366-83a0c7a7-783b-4a8b-a143-f600a8d2cbc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNjA1NjUsIm5iZiI6MTcyNDA2MDI2NSwicGF0aCI6Ii8yMjAwODk5LzMxNzAxMTM2Ni04M2EwYzdhNy03ODNiLTRhOGItYTE0My1mNjAwYThkMmNiYzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTlUMDkzNzQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTY4NDJiOGE0M2U0YjY1OThkZDVlMTBhOWM1NWE0ZmJjMDllODA5ZDUxNDY0ODdmZjdhYzZlOWM5ZmFiOWQ5MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Q1pecSv9KSAPphPVWqFuL40zd3X0uuTxuMZ9D0oSaWU)
After
![Screenshot 2024-03-26 at 12 08 28 PM](https://private-user-images.githubusercontent.com/2200899/317011073-5c274936-5ff6-428e-a889-482543262ccb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQwNjA1NjUsIm5iZiI6MTcyNDA2MDI2NSwicGF0aCI6Ii8yMjAwODk5LzMxNzAxMTA3My01YzI3NDkzNi01ZmY2LTQyOGUtYTg4OS00ODI1NDMyNjJjY2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MTlUMDkzNzQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWFhODhjZGVhYzJkZjMyOTc3MDQ0ZjQ0OWMzOTI4ZDdiNTVjNWFkMTBiMDQ2MWFiZWQ1ZjNlZDQzYmU4NmU3ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rc5cU2kbsGIQttd4a87E7XhBqnUtUIWOmzKeiI15X3Q)
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.