Re-map class-name color token in CodeBlock #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristinLBradley
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
@jorytindall Looks good to me. Do you want to change this from a draft?
|
@KristinLBradley thanks for the quick review! Added a changeset as well. I don't think this requires any changes in design, the only thing I can think of is creating a parallel language variant in the Figma component for JavaScript (which we don't have), but I'll discuss in our design sync tomorrow. |
majedelass
approved these changes
Mar 27, 2024
|
@jorytindall This looks good to merge when you are ready. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Draft/Example PR. As far as I can tell, this change only affects our JavaScript examples in the showcase.
Showcase 👉 https://hds-showcase-git-jt-code-block-class-name-hashicorp.vercel.app/components/code-block#highlight-lines
📸 Screenshots
Before
After
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.