Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(showcase): speed up tests in CI #2176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(showcase): speed up tests in CI #2176

wants to merge 1 commit into from

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Jun 19, 2024

πŸ“Œ Summary

This change cuts component tests in CI by 50%, today on average it takes around 4 minutes with this change we reduce it to 2 minutes.

The only potential issue I see is this message:

[percy] Error: This organization has exceeded the limits of the Percy BrowserStack plan. Administrators can upgrade here: https://percy.io/organizations/587d9efb/billing

πŸ› οΈ Detailed description

πŸ“Έ Screenshots

Before:

Screenshot 2024-06-18 at 7 47 49β€―PM

After:

Screenshot 2024-06-18 at 7 48 27β€―PM

πŸ”— External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


πŸ‘€ Component checklist

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Jun 19, 2024
Copy link

vercel bot commented Jun 19, 2024

You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@aklkv aklkv force-pushed the feat/speedup-test branch 5 times, most recently from 912aeed to 490ca6a Compare June 19, 2024 02:38
@aklkv aklkv marked this pull request as ready for review June 19, 2024 02:49
@aklkv aklkv force-pushed the feat/speedup-test branch 6 times, most recently from 3e6d3b4 to 0a03478 Compare June 19, 2024 03:14
@Dhaulagiri
Copy link
Contributor

FWIW the percy message is not unique to this PR. I see it in others as well.

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, using ember-exam sounds like a good idea for introducing parallel testing.

I've only been able to compare test:ember (not including the VRT testing in Percy) and the differences are marginal (2m12s, compared to 2m20s for main); However, it could make all the difference on test:ember:percy, but we seem to have some challenges around using Percy so not able to test that atm.

@@ -6,6 +6,7 @@
'use strict';

module.exports = {
parallel: process.env.CI ? -1 : 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity, setting parallel execution to -1 means auto-detect and use the maximum number of parallel processes possible, while setting it to 1 means executing tests serially, one after the other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jun 25, 2024 10:28am
hds-website βœ… Ready (Inspect) Visit Preview Jun 25, 2024 10:28am

@aklkv
Copy link
Contributor Author

aklkv commented Jun 20, 2024

Generally, using ember-exam sounds like a good idea for introducing parallel testing.

I've only been able to compare test:ember (not including the VRT testing in Percy) and the differences are marginal (2m12s, compared to 2m20s for main); However, it could make all the difference on test:ember:percy, but we seem to have some challenges around using Percy so not able to test that atm.

I tried adding ember-exam to website tests but it didn't result in much savings so I thought there wouldn't be much sense in adding it at this stage. I am happy to add this instrumentation here as well for consistency.

On the other hand showcase test were much more cooperative and we can see ~2 min saving

@aklkv
Copy link
Contributor Author

aklkv commented Jun 20, 2024

FWIW the percy message is not unique to this PR. I see it in others as well.

oh, good to know I thought ember-exam parallel runs triggered this warning

feat(showcase): speed up tests in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants