Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated design tokens for old semantic colors #327

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented May 30, 2022

📌 Summary

This is a follow-up of https://github.com/hashicorp/design-system-tokens/pull/78/ where we re-organized the semantic colors releasing new design tokens in line with the new naming convention, and deprecating the old ones (to avoid breaking changes).

🛠️ Detailed description

In this PR I have:

  • removed the old deprecated semantic colors
  • re-generated the design tokens in output
  • removed banner about deprecated colors in the documentation

Notice: searching the entire HashiCorp codebases via GitHub search, I've found only these occurrences:

So it's pretty safe to release as a patch, and open two PRs for DevDot and Cloud UI to update their codebases.


👀 How to review

👉 Review commit-by-commit or by files changed

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.


@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: a46fc03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/design-system-tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview May 30, 2022 at 11:34AM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview May 30, 2022 at 11:34AM (UTC)

Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (double checked our component code just in case, too)

@didoo didoo merged commit cbed579 into main Jun 1, 2022
@didoo didoo deleted the remove-deprecated-tokens branch June 1, 2022 09:45
@hashibot-hds hashibot-hds mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants