Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback to users of FlightIcon when icon name is not correct #580

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 27, 2022

📌 Summary

As follow-up of this Slack conversation I have created a small PR that adds a feedback for the consumers of FlightIcons if a non-existing icon name is provided.

Example of what a developer would see in the console:
screenshot_1817

🛠️ Detailed description

In this PR I have:

  • updated the build step in the Flight icons pipeline , to add the generation of a "index" file with the list of all the Flight icon names
  • updated the EmberFlightIcon component/addon to throw an error if a non-existing icon name is used
  • updated the integration tests for EmberFlightIcon

👀 How to review

👉 Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Sep 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
hds-components ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Sep 29, 2022 at 1:13PM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Sep 29, 2022 at 1:13PM (UTC)

@didoo didoo force-pushed the flight-icons-add-feedback-to-users branch from ba564b6 to 1861954 Compare September 27, 2022 18:07
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022

🦋 Changeset detected

Latest commit: 55f38cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hashicorp/flight-icons Minor
@hashicorp/ember-flight-icons Major
@hashicorp/design-system-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 27, 2022 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 27, 2022 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 27, 2022 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 27, 2022 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 28, 2022 12:49 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 28, 2022 12:49 Inactive
@didoo didoo force-pushed the flight-icons-add-feedback-to-users branch from 38e35db to 4ca0d21 Compare September 28, 2022 14:13
@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 28, 2022 14:14 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 28, 2022 14:15 Inactive
@didoo didoo force-pushed the flight-icons-add-feedback-to-users branch from 4ca0d21 to 013d10e Compare September 28, 2022 14:15
@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 28, 2022 14:16 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 28, 2022 14:17 Inactive
@didoo didoo marked this pull request as ready for review September 28, 2022 14:26
@didoo didoo changed the title [WIP] Add feedback to users of FlightIcon when icon name is not correct Add feedback to users of FlightIcon when icon name is not correct Sep 28, 2022
@vercel vercel bot temporarily deployed to Preview – hds-flight-website September 29, 2022 13:12 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components September 29, 2022 13:13 Inactive
@@ -0,0 +1,5 @@
---
"@hashicorp/flight-icons": minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do you need two separate change logs?

Copy link
Contributor Author

@didoo didoo Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelSumner using the yarn changelog command, it was not clear (to me) how to apply different semver increments to the packages, so I kept it simple and run it twice (and this created two files). I don't think this should make a difference for changelog (@Dhaulagiri can you confirm this?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to combine them via yarn changelog but in practice I don't think it'll make a difference: changesets will be able to figure it out similar to if these were part of completely separate changes.

@didoo didoo merged commit 6584c3d into main Sep 30, 2022
@didoo didoo deleted the flight-icons-add-feedback-to-users branch September 30, 2022 13:42
@hashibot-hds hashibot-hds mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants