Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs component - Add component-specific design tokens #629

Merged
merged 3 commits into from Oct 12, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Oct 12, 2022

πŸ“Œ Summary

Like we did before for other components, we want to add component-specific design tokens for the Tabs because will make easier to adopt them in other consumer codebases (eg. DevDov) and to push small design tweaks/changes in the future if needed.

πŸ› οΈ Detailed description

In this PR I have:

  • added design tokens for Tabs component
  • regenerated design tokens in output

πŸ‘€ How to review

πŸ‘‰ Review by files changed

Reviewer's checklist:

  • Confirm that PR has a changelog update via Changesets if needed

πŸ’¬ Please consider using conventional comments when reviewing this PR.

@vercel
Copy link

vercel bot commented Oct 12, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
hds-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Oct 12, 2022 at 5:45PM (UTC)
hds-flight-website βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Oct 12, 2022 at 5:45PM (UTC)
hds-website βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Oct 12, 2022 at 5:45PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

πŸ¦‹ Changeset detected

Latest commit: a079992

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hashicorp/design-system-tokens Minor
@hashicorp/design-system-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, just one percy test failing

@didoo didoo merged commit 797a659 into hds-576-tabs-component Oct 12, 2022
@didoo didoo deleted the tabs-tokens branch October 12, 2022 18:27
@hashibot-hds hashibot-hds mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants