New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "focus-ring" tokens and mixins to support both "active" and "critical" colors #98
Conversation
… and “critical” variants
🦋 Changeset detectedLatest commit: 411cd9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/2oFBmED7Q8bhcp59ovzzg51JcUXZ hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/3ukMvcGZa6hzgVkNVJQupdtdfhuS |
@MelSumner I have refactored the |
Note: re-opened because I deleted the branch by mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super useful, thank you for doing this! 👍
📌 Summary
The
Dropdown
components has "link" items that have not onlyaction
but alsocritical
colors (see #68 for example).At the moment the "focus-ring" tokens and mixins support only the
action
🛠️ Detailed description
In this PR I have:
Notice: I have bumped the
minor
change for the@hashicorp/design-system-tokens
(despite being a breaking change) and thepatch
change for the@hashicorp/design-system-components
because of the fact that we have not yet released a version1.0.0
of the packages. I'll take care to open a PR for DevDot to update their codebase and take care of the breaking change (just a matter or renaming a classname in a couple of places).📸 Screenshots
👀 How to review
👉 Review commit-by-commit or by files changed (as you prefer)
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.